NekR#324, make networkFirstResponse configurable

BowlingX · Dec 7, 2017 · 0cdd470 · 0cdd470
1 parent 0845c39
commit 0cdd470
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -50,6 +50,7 @@ const defaultOptions = {
       cache: void 0
     },
     minify: null,
+    shouldServeFromNetwork: (response) => response.ok,
     navigateFallbackForRedirects: true
   },
 

diff --git a/src/misc/sw-template.js b/src/misc/sw-template.js
@@ -375,7 +375,7 @@ function WebpackServiceWorker(params, helpers) {
   function networkFirstResponse(event, urlString, cacheUrl) {
     return fetch(event.request)
       .then((response) => {
-        if (response.ok) {
+        if (params.shouldServeFromNetwork(response, urlString, cacheUrl)) {
           if (DEBUG) {
             console.log('[SW]:', `URL [${ urlString }] from network`);
           }

diff --git a/src/service-worker.js b/src/service-worker.js
@@ -16,7 +16,7 @@ export default class ServiceWorker {
     this.minify = options.minify;
     this.output = options.output.replace(/^\.\/+/, '');
     this.publicPath = options.publicPath;
-
+    this.shouldServeFromNetwork = options.shouldServeFromNetwork;
     this.basePath = null;
     this.location = null;
     this.pathRewrite = null;
@@ -185,7 +185,7 @@ export default class ServiceWorker {
         },
 
         externals: externals,
-
+        shouldServeFromNetwork: this.shouldServeFromNetwork,
         hashesMap: hashesMap,
         navigateFallbackURL: this.navigateFallbackURL,
         navigateFallbackForRedirects: this.navigateFallbackURL ?