You don't mind every single possible optimization right?

[MikuAuahDark]

If so, then read along.

cs2drecorder/Recorder/GameReplay.lua

Line 42 in eb1ca1a

io.write(tostring(timeStamp).." = "..state:ToString());

Don't concat when passing string to io.write. io.write accepts arbitrary arguments which has same effect as concatention, so you can do io.write(tostring(timeStamp), " = ", state:ToString()) instead.

cs2drecorder/Recorder/GameReplay.lua

Line 59 in eb1ca1a

io.Write(tostring(timeStamp).." = "..self.stateList[timeStamp]:ToString());

Same as above.

cs2drecorder/Recorder/GameReplay.lua

Lines 92 to 113 in eb1ca1a

	local strWrite = tostring(self.version).." = [ \n";
	-- foreach gameStat to save
	for _,v in ipairs(Config.gameStats) do
	strWrite = strWrite.. " "..v.." = "..tostring(game(v)).."\n";
	end
	strWrite = strWrite.."]; \n";
	-- foreach player
	for _,id in ipairs(player(0,"tableliving")) do
	strWrite = strWrite..tostring(id).." = ( \n";
	for _,v in ipairs(Config.playerStats) do
	strWrite = strWrite.." "..v.." = "..player(id,v).."\n";
	end
	strWrite = strWrite.."); \n";
	end
	io.write(strWrite);

Let strWrite be table and for every string you want to add, append into the table with strWrite[#strWrite + 1] = str. Then when writing, do io.write(table.concat(strWrite)). Those string concatenation can be expensive (both in terms of performance and memory) once strWrite is large.

cs2drecorder/Recorder/GameState.lua

Lines 20 to 37 in eb1ca1a

	function GameState:ToString()
	local strReturn = "{ \n"
	for _,v in pairs(self.list) do
	strReturn = strReturn.." { '"..tostring(v[1]).."'";
	for i=2,3 do
	strReturn = strReturn..", '"..tostring(v[i]).."'";
	end
	strReturn = strReturn.." }, \n"
	end
	strReturn = strReturn .. "}; \n"
	return strReturn;
	end

Same strategy as above, create temporary table then concatenate in one go with table.concat.

cs2drecorder/Recorder/Assembler.lua

Lines 18 to 24 in eb1ca1a

	function Assembler:Assemble()
	local output = "";
	for k,v in ipairs(self.list) do
	output = output..tostring(v)..self.delimiter;
	end
	return output;
	end

Same strategy as above.

cs2drecorder/Recorder/Addhooks.lua

Line 82 in eb1ca1a

for _,id in ipairs(player(0,"tableliving")) do

If you're using vanilla Lua 5.1 (not LuaJIT), use pairs.

As a side note: Files opened with io.open is buffered by default. It's usually okay to left the buffer setting as-is, but if you want (which may or may not impact performance), you can set the buffering mode with file:setvbuf.

[VADemon]

Don't concat when passing string to io.write. io.write accepts arbitrary arguments which has same effect as concatention

Except under the hood in standard Lua, io.write() makes a system call for each argument instead of concatenation. That's slower, especially on Intel CPUs and the endless security patches.

See update below

[MikuAuahDark]

Buffering exist exactly for that reason. Yeah that will affect performance if you turn off buffering, but in most cases buffering is turned on by default. Pada tanggal Jum, 5 Feb 2021 03.51, VADemon <notifications@github.com> menulis:

…

Don't concat when passing string to io.write. io.write accepts arbitrary arguments which has same effect as concatention Except under the hood in standard Lua, io.write() makes a system call for each argument instead of concatenation. That's slower, especially on Intel CPUs and the endless security patches. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZHFFXW4MZOK6ZQ4EZJRYTS5L3FZANCNFSM4XC3SZMQ> .

[VADemon]

I concur, Lua does a call to fwrite (POSIX) under the hood for each argument of io.write(), but appears to be fastest still.

"Octuple" = File:write(chars[i], chars[i+1], chars[i+2], chars[i+3],chars[i+4], chars[i+5], chars[i+6], chars[i+7])

$ filewrite.lua
// time in seconds, e.g. 0.35 = 350ms
// SIZE = Size of random characters written to file

SIZE in MiB:1
single Character per call: :   0.15
octuple Character per call: :   0.09
concat8x Character per call: :   0.11
tableconcat8x Character per call: :   0.08

SIZE in MiB:2
single Character per call: :   0.35
octuple Character per call: :   0.15
concat8x Character per call: :   0.21
tableconcat8x Character per call: :   0.20

SIZE in MiB:16
single Character per call: :   2.59
octuple Character per call: :   1.37
concat8x Character per call: :   1.58
tableconcat8x Character per call: :   1.63

filewrite.lua.txt