Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor config #10

Merged
merged 6 commits into from
May 27, 2017
Merged

Refactor config #10

merged 6 commits into from
May 27, 2017

Conversation

denisgrenader
Copy link
Contributor

No description provided.

@shubhrojroy shubhrojroy self-assigned this May 26, 2017
shubhrojroy
shubhrojroy approved these changes May 26, 2017
View reviewed changes
Copy link
Contributor

@shubhrojroy shubhrojroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

shubhrojroy
shubhrojroy requested changes May 27, 2017
View reviewed changes
Copy link
Contributor

@shubhrojroy shubhrojroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in class name of BatchSizeManager

src/main/scala/com/box/castle/core/config/BatchSizeMangerConfig.scala Outdated
import org.joda.time.Duration
import BatchSizeMangerConfig._

case class BatchSizeMangerConfig(samplingSlots: Int = DefaultSamplingSlots,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be BatchSizeManager. 'a' got dropped.

shubhrojroy
shubhrojroy approved these changes May 27, 2017
View reviewed changes
Copy link
Contributor

@shubhrojroy shubhrojroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@denisgrenader denisgrenader merged commit 8046193 into master May 27, 2017
@denisgrenader denisgrenader deleted the refactorConfig branch May 27, 2017 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhrojroy shubhrojroy shubhrojroy approved these changes

Assignees

@shubhrojroy shubhrojroy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@denisgrenader @shubhrojroy