Handling 0 byte reads in BatchSizeManager #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisgrenader
requested changes
May 16, 2017
| @@ -28,11 +29,11 @@ trait CommitterActorStates { | |||
|
|
|||
| def waitingToRestart: Receive | |||
|
|
|||
| def becomePreparingToCommitBatch(batch: CastleMessageBatch, metadata: Option[String]): Unit | |||
| def becomePreparingToCommitBatch(message: Either[Success,NoMessages], metadata: Option[String]): Unit | |||
There was a problem hiding this comment.
this should be:
message: Either[CastleMessageBatch, NoMessages]
|
|
||
| def preparingToCommitBatch: Receive | ||
|
|
||
| def becomeCommittingBatch(userCommitters: IndexedSeq[Committer], batch: CastleMessageBatch, metadata: Option[String]): Unit | ||
| def becomeCommittingBatch(userCommitters: IndexedSeq[Committer], message: Either[Success,NoMessages], metadata: Option[String]): Unit |
There was a problem hiding this comment.
this should be:
message: Either[CastleMessageBatch, NoMessages]
| } | ||
|
|
||
| case success: FetchData.Success => | ||
| becomePreparingToCommitBatch(Left(success), consumerMetadata) |
There was a problem hiding this comment.
becomePreparingToCommitBatch(Left(success.batch), consumerMetadata)
|
|
||
|
|
||
| private[committer] trait PreparingToCommitBatch extends CommitterActorBase with CommitterActorStates { | ||
| self: Actor with RouterRequestManager with Logging => | ||
|
|
||
| private case class CommitBatch(userCommitters: IndexedSeq[Committer], batch: CastleMessageBatch, metadata: Option[String]) | ||
| private case class CommitBatch(userCommitters: IndexedSeq[Committer], message: Either[Success, NoMessages], metadata: Option[String]) |
There was a problem hiding this comment.
batch: Either[CastleMessageBatch, NoMessages]
|
|
||
| override def becomePreparingToCommitBatch(batch: CastleMessageBatch, metadata: Option[String]): Unit = { | ||
| override def becomePreparingToCommitBatch(message: Either[Success, NoMessages], metadata: Option[String]): Unit = { |
version.sbt
Outdated
| @@ -1 +1 @@ | |||
| version := "1.0.1" | |||
| version := "1.0.2" | |||
There was a problem hiding this comment.
let's not change the version as part of this commit
denisgrenader
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.