Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not scroll in chrome 74 or highter #80

Closed
gdutwyg opened this issue Aug 21, 2019 · 7 comments
Closed

can not scroll in chrome 74 or highter #80

gdutwyg opened this issue Aug 21, 2019 · 7 comments

Comments

@gdutwyg
Copy link

gdutwyg commented Aug 21, 2019

Bug report

Current behavior:
in the chorme 74,the page I can slide down, but i can't slide up. And it is normal if i use chrome 66 or lower
Expected behavior:
the page can slide down or slide up
JSFiddle URL for demo with bug:
https://jsbin.com/wisiligeke/1/edit?html,js,console,output
Browsers affected:
mobile chorme 74

@faelsoto
Copy link
Member

@pateketrueke it's the issue we were talking about last week.

@gdutwyg we're looking into it, a quick fix would be to add a new parameter:

shouldPullToRefresh(){
   return !window.location.top;
}

@gdutwyg
Copy link
Author

gdutwyg commented Aug 22, 2019

@faelsoto oh,it seems that the code can not fix it, and i add the code,also it is not normal in chorme 66.

@faelsoto
Copy link
Member

faelsoto commented Aug 22, 2019

I'm sorry, I made up that property, don't know what I was thinking.

The fix as we have it in production is this:

shouldPullToRefresh(){
   !window.scrollY;
}

@gdutwyg
Copy link
Author

gdutwyg commented Aug 22, 2019

ok, it works. i hope you can fix it in next version, thanks.

@faelsoto
Copy link
Member

It's fixed, please download v0.1.19

@crusy
Copy link

crusy commented Sep 10, 2019

It's fixed, please download v0.1.19

It's not on npm yet, or is it?
For the records: 0.1.19 includes PR #81, right? It's kind of confusing, because this issue is #80 😉

@pateketrueke
Copy link
Collaborator

Hi @crusy please pull v0.1.19 from NPM, it's published now.

And yeah, v0.1.19 includes both PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants