Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): 🐛 fixing miscellaneous issues in workflows #465

Merged
merged 32 commits into from
May 14, 2023
Merged

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented May 6, 2023

Closes: #378

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except `.md`, `.yml`, `*.json`?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

IMPORTANT: Make sure to check the `Allow edits from maintainers` box below this window

@github-actions github-actions bot added the 🐛 pr: bug fix PR which fixes a bug label May 6, 2023
@WasiqB WasiqB self-assigned this May 6, 2023
@ghost
Copy link

ghost commented May 6, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@WasiqB WasiqB marked this pull request as ready for review May 14, 2023 09:16
@WasiqB WasiqB requested a review from a team as a code owner May 14, 2023 09:16
@WasiqB WasiqB requested a review from mfaisalkhatri May 14, 2023 09:16
@sonarcloud
Copy link

sonarcloud bot commented May 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

67.3% 67.3% Coverage
0.0% 0.0% Duplication

@WasiqB WasiqB merged commit 3e9f4af into develop May 14, 2023
21 of 22 checks passed
@WasiqB WasiqB deleted the issue-378 branch May 14, 2023 09:30
WasiqB added a commit that referenced this pull request May 14, 2023
Replaced Web Legacy protocol with W3C protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 pr: bug fix PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant