Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): ✨ made boyka config path configurable #609

Merged
merged 14 commits into from
Sep 19, 2023
Merged

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented Sep 18, 2023

Closes: #602

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@ghost
Copy link

ghost commented Sep 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions github-actions bot added the 🚀 pr: new feature PR which introduces new features label Sep 18, 2023
@WasiqB WasiqB self-assigned this Sep 19, 2023
@WasiqB WasiqB linked an issue Sep 19, 2023 that may be closed by this pull request
3 tasks
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@WasiqB WasiqB marked this pull request as ready for review September 19, 2023 10:51
@WasiqB WasiqB requested a review from a team as a code owner September 19, 2023 10:51
@WasiqB WasiqB merged commit 20713ca into develop Sep 19, 2023
24 checks passed
@WasiqB WasiqB deleted the issue-602 branch September 19, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 pr: new feature PR which introduces new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Boyka config path configurable
1 participant