Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket color fix #6

Closed
wants to merge 1 commit into from
Closed

Bracket color fix #6

wants to merge 1 commit into from

Conversation

toliklunev
Copy link
Contributor

Bracket color property should be more specific, than tag color, to differ, and be more similar to Sublime Monokai theme.

From:
2015-01-01 22-38-00

To:
2015-01-01 22-38-32

@sbruchmann
Copy link
Contributor

Nice catch! Does .cm-bracket apply to other modes as well? If so, we should use addModeClass and .cm-html. I’ll take a look at it as soon as I am ready to work again. Happy new year!

@toliklunev
Copy link
Contributor Author

I'm don't tested it on other modes yet. Happy new year too :-)

@marcelgerber
Copy link

I just looked at the CM source for XML (HTML), JS, CSS (I'd call these the "main Brackets languages") and CoffeeScript and I did only see .cm-bracket being used in XML (HTML).

@sbruchmann
Copy link
Contributor

Thanks, @marcelgerber! Then this should be ready to be merged. Just a second!

@sbruchmann sbruchmann closed this in ed3a112 Jan 1, 2015
@sbruchmann
Copy link
Contributor

Thanks, @CodeFucker! Merged.

@toliklunev
Copy link
Contributor Author

@sbruchmann Cool, that's great.

@toliklunev toliklunev deleted the bracket-fix branch January 2, 2015 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants