-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pylance support #306
Add Pylance support #306
Conversation
@mwelcker Thank you for the PR. Great start, but based on #152 (comment) I'm not sure if just adding One idea for handling this could be to add a "language-server" parameter to the jinja2 context used for rendering the file. micropy-cli/micropy/project/template.py Lines 171 to 194 in 7c71655
and sets the property to pylance. You could then extend the jinja template to check for this parameter and render the optimal configuration (based on the discussion in #152). Lemme know what you think, thanks. |
Codecov ReportBase: 93.58% // Head: 93.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 93.58% 93.46% -0.13%
==========================================
Files 50 48 -2
Lines 2652 2618 -34
==========================================
- Hits 2482 2447 -35
- Misses 170 171 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
In favor of #379 |
I just added Pylance autocompletion support.
Pylance uses
python.analysis.extraPaths
instead ofpython.autoComplete.extraPaths
.Fix #152