Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Search/Retrieve Stubs Directly from micropy-stubs #60

Merged
merged 5 commits into from
Oct 13, 2019

Conversation

BradenM
Copy link
Owner

@BradenM BradenM commented Oct 12, 2019

Removes the need for an external AWS S3 bucket for hosting stub package archives and uses micropy-stubs directly instead.

This closes BradenM/micropy-stubs#5

Instead of downloading/searching for stubs via archives uploaded to S3, directly use the micropy-stubs git repo
@coveralls
Copy link

coveralls commented Oct 12, 2019

Pull Request Test Coverage Report for Build 388

  • 22 of 24 (91.67%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 98.922%

Changes Missing Coverage Covered Lines Changed/Added Lines %
micropy/utils/helpers.py 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
micropy/stubs/stubs.py 2 97.97%
micropy/utils/helpers.py 2 97.56%
Totals Coverage Status
Change from base Build 382: -0.06%
Covered Lines: 1377
Relevant Lines: 1392

💛 - Coveralls

@BradenM BradenM merged commit 4833a74 into master Oct 13, 2019
@BradenM BradenM deleted the feat/mp-stub-repo branch October 13, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Repo as Stub Source
2 participants