New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve Pylint Syntax #97
Conversation
previously searched for sys.path.insert, which is no longer used.
bad test dependency randomizes the stub ordering (correct frozen -> stubs order, but just random as to which stub paths come first). Will fix
also force unique values in pylintrc template. really only an issue with the poorly written test that I will one day fix.
Here is an overview of what got changed by this pull request: Coverage increased per file
===========================
+ micropy/project/modules/packages.py 1
Coverage decreased per file
===========================
- micropy/config/config.py -13
- micropy/project/template.py -1
Clones added
============
- micropy/project/template.py 2
See the complete overview on Codacy |
@BradenM can I help with this? Also, I was noticing your comment about adding src/lib IF it exists. For a new project, can we force it into existence and always add it? I feel like its the correct coding practice. |
For sure! IIRC, I believe I finished the implementation and just needed to fix some tests... Looking back, I may have been a bit (a lot) too strict with code coverage... and as a result there are a lot of poorly written, flaky tests 😬. So just navigating that mess should be all thats left haha. See #79 for more details. As for requiring Perhaps a configuration option or something may be a good idea though... |
I tend to think opinionated is good, sorta fits the Zen of Python that there should be one way... but of course there are exceptions. ;-) I wonder if 'power' users would fine that if you selected create boot.py and main.py you also added src/lib. That seems like it fits together. I'll try to have a look, and I might get stuck.. but I'll give it a go. This week is very odd for me with the US Holiday and some additional time potentially away from internet access, so if I go dark... I'll be back the following week. |
@askpatrickw Think I can agree with creating And all good! My schedule has been a bit wild recently as well haha, I appreciate your help! |
I've spent a few hours looking at this and I am stumped so I'm going to back away on this. |
Changes
.pylintrc
as outlined in Improve pylint path syntax and add ./src/lib #96src/lib
if such folder exists.pylintrc
updating flow