rename ui selection to selectino_str

BradyAJohnston · Jun 17, 2024 · 1b5e836 · 1b5e836
1 parent cb3dbec
commit 1b5e836
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/molecularnodes/io/md.py b/molecularnodes/io/md.py
@@ -129,7 +129,7 @@ class TrajectorySelectionItem(bpy.types.PropertyGroup):
         default="custom_selection",
     )
 
-    selection: StringProperty(  # type: ignore
+    selection_str: StringProperty(  # type: ignore
         name="Selection String",
         description="String that provides a selection through MDAnalysis",
         default="name CA",

diff --git a/molecularnodes/io/parse/mda.py b/molecularnodes/io/parse/mda.py
@@ -108,12 +108,9 @@ def _update_selections(self):
                 # if the same selection string, test to see if updating. If not updating
                 # then move on - if updating then call the set selection method to update
                 # the selection on the mesh
-                if selection.selection_str != sel.selection:
-                    # if the selection string has changed, we need to delete the old selection
-                    # and thus the old atom group, and create a new atom selection and
-                    # AtomGroup
+                if selection.selection_str != sel.selection_str:
                     selection.change_selection(
-                        selection_str=sel.selection,
+                        selection_str=sel.selection_str,
                         updating=sel.updating,
                         periodic=sel.periodic,
                     )
@@ -124,7 +121,7 @@ def _update_selections(self):
                 # if the selection doesn't exist for the universe, create a new one
                 self.add_selection(
                     name=sel.name,
-                    selection_str=sel.selection,
+                    selection_str=sel.selection_str,
                     updating=sel.updating,
                     periodic=sel.periodic,
                 )

diff --git a/molecularnodes/ui/panel.py b/molecularnodes/ui/panel.py
@@ -156,7 +156,7 @@ def panel_custom_selections(layout, context):
         row.prop(item, "name")
         row.prop(item, "updating")
         row.prop(item, "periodic")
-        col.prop(item, "selection")
+        col.prop(item, "selection_str")
 
 
 def panel_object(layout, context):