Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix magnesium color bug #264

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

PlethoraChutney
Copy link
Contributor

The color-by-element node was mis-wired between atomic numbers 14 and 15. This resolves #254.

image

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4e8225d) 53.73% compared to head (f012450) 53.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   53.73%   53.73%           
=======================================
  Files          15       15           
  Lines        1952     1952           
=======================================
  Hits         1049     1049           
  Misses        903      903           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradyAJohnston
Copy link
Owner

Fabulous! I still haven't come up with a good way of actually versioning the hand-made nodes via git (.blend files are opaque to it) so I think we basically have to rely upon using tests to ensure that things don't change majorly when people edit the files.

@BradyAJohnston BradyAJohnston merged commit 5a3f1b7 into BradyAJohnston:main Jul 5, 2023
4 of 5 checks passed
BradyAJohnston added a commit that referenced this pull request Sep 14, 2023
BradyAJohnston added a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't change color of ions (?)
2 participants