Dev entity fix #284
Merged
Dev entity fix #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 60.61% 60.72% +0.10%
==========================================
Files 19 19
Lines 2260 2266 +6
==========================================
+ Hits 1370 1376 +6
Misses 890 890
☔ View full report in Codecov by Sentry. |
BradyAJohnston
added a commit
that referenced
this pull request
Sep 14, 2023
fix: fixes correct assignment of `entity_id`
BradyAJohnston
added a commit
that referenced
this pull request
Sep 14, 2023
fix: fixes correct assignment of `entity_id`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes adding of the
entitythat was getting mixed up on some structures because of author-defined chain names for ions etc.Also adds some diagnostic console printing for debugging opening of structures