Refactor: Style Surface Node #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemingly updates were lost
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
=======================================
Coverage 77.47% 77.47%
=======================================
Files 40 40
Lines 3432 3432
=======================================
Hits 2659 2659
Misses 773 773 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something weird happened with the previous PR, replicating it here with some minor tweaks.
Updates the style surface node, for better alignment with traditional gaussian surface or solvent accessible surface.
Increasing probe size gives the more typical 'solvent accessible surface' look.
This should still not be considered exact equivalents to those in other programs, as they are still only approximations through the currently available geometry nodes.
The calculation is slightly slower (2x slower), but the trade off with the much more accurate surface is worth it.