Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Periphery.sol for interacting with Vault.sol #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Periphery.sol for interacting with Vault.sol #5

wants to merge 9 commits into from

Conversation

Pradeep-selva
Copy link
Member

No description provided.

Bapi-Reddy
Bapi-Reddy reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@Bapi-Reddy Bapi-Reddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't consider the balances from vault to calculate the swap amount.

0xad1onchain
0xad1onchain requested changes Sep 17, 2021
View reviewed changes
Copy link
Collaborator

@0xad1onchain 0xad1onchain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary transactions in deploy.js
Remove multicall from the commit for now

@Pradeep-selva
Copy link
Member Author

Remove unnecessary transactions in deploy.js
Remove multicall from the commit for now

Can you check now. Fixed those

@Pradeep-selva Pradeep-selva added the enhancement New feature or request label Sep 18, 2021
@Bapi-Reddy
Copy link
Member

Add periphery changes https://github.com/Brahma-fi/aastra-periphery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bapi-Reddy Bapi-Reddy Bapi-Reddy left review comments

@0xad1onchain 0xad1onchain Awaiting requested review from 0xad1onchain

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pradeep-selva @Bapi-Reddy @0xad1onchain