Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!(deps): update to v5 spec #112

Merged
merged 6 commits into from
Jun 30, 2023
Merged

chore!(deps): update to v5 spec #112

merged 6 commits into from
Jun 30, 2023

Conversation

JagadeeshKaricherla-branch
Copy link
Contributor

@JagadeeshKaricherla-branch JagadeeshKaricherla-branch commented Jun 22, 2023 •
edited by gdeluna-branch

Reference

SDK-1931 -- Update plugin to the new Capacitor v5 spec

Summary

Update this plugin to the new capacitor v5 spec based on https://capacitorjs.com/docs/updating/plugins/5-0

Motivation

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing Instructions

cc @BranchMetrics/saas-sdk-devs for visibility.

nsingh-branch
nsingh-branch approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@nsingh-branch nsingh-branch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to add the latest alpha to my test app and run on both platforms. LGTM

@gdeluna-branch gdeluna-branch changed the title chore(deps): update to v5 spec chore!(deps): update to v5 spec Jun 30, 2023
@gdeluna-branch gdeluna-branch merged commit e731a43 into master Jun 30, 2023
2 checks passed
@gdeluna-branch gdeluna-branch mentioned this pull request Jun 30, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsingh-branch nsingh-branch nsingh-branch approved these changes

@gdeluna-branch gdeluna-branch Awaiting requested review from gdeluna-branch

@echo-branch echo-branch Awaiting requested review from echo-branch

@NidhiDixit09 NidhiDixit09 Awaiting requested review from NidhiDixit09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JagadeeshKaricherla-branch @nsingh-branch @gdeluna-branch