resolve setDebug promise on Android & ios with passed-in value #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worth noting that it looks like doing the following: initSession() setDebug(true) setDebug(false) will currently leave the debug state as true since false is pretty much a no-op. This commit at least fixes (on iOS) so that if you do initSession() then setDebug(false), it doesn’t set debug mode to on. Both platforms now return a proper bool value of true/false.
|
I noticed this issue in my testing as well - I'm going to look at this over the weekend on Android, too, and try to add to this PR & get it merged in. thanks for your contributions! |
|
Sounds good. No problem. |
|
Looks great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worth noting that it looks like doing the following:
initSession()
setDebug(true)
setDebug(false)
will currently leave the debug state as true since false is pretty much
a no-op. This commit at least fixes (on iOS) so that if you do
initSession() then setDebug(false), it doesn’t set debug mode to on.
Both platforms now return a proper bool value of true/false.