Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepLink opens app but callback in not firing until the app goes to background #825

Closed
hushhash opened this issue Apr 20, 2018 · 4 comments
Assignees

Comments

@hushhash
Copy link

Two targets on the same code base with different configurations, the one that's in production is having a critical and strange issue:

  • App is running
  • User clicks on a deeplink from outside the app
  • App is triggered and is opened and one of two things happen:
  1. On the test target, initSessionWithLaunchOptions:andRegisterDeepLinkHandler: callback is being called immediately as expected as a response to clicking the link.
  2. On the production target the callback back isn't called until the app goes to background (for example: opening the iOS notification screen).

because the app is refocused from the link, and because the deeplink is called, only not in the right time, the configuration seems to be ok.

One thing I've noticed is that in regards to the app delegate, on the production target the deep link triggers:

  • (BOOL)application:(UIApplication *)app openURL:(NSURL *)url options:(NSDictionary<NSString *,id> *)options {
    While the other target's deeplink triggers
  • (BOOL)application:(UIApplication *)application continueUserActivity:(NSUserActivity *)userActivity restorationHandler:(void(^)(NSArray * __nullable restorableObjects))restorationHandler
@E-B-Smith
Copy link
Contributor

Are you using the same URL scheme and applink domains defined correctly in both configurations?

Check that the URL scheme defined in your Info.plist is correct in both, and that your associated domains are set up in your app's capabilities section.

@E-B-Smith E-B-Smith self-assigned this Apr 20, 2018
@hushhash
Copy link
Author

I was just able to finally solve this, the URL scheme and app capabilities were fine.

What solved it was moving the url scheme to be first in the array of plist URLType->URLSchemes.

Still a bug.

@E-B-Smith
Copy link
Contributor

I'm glad you solved it. I'll look into why it has to be the first though.

E-B-Smith added a commit that referenced this issue Apr 20, 2018
* Updated our URI scheme filter that finds a URI scheme for the partner's app.
* Updated the docs to clarify that the partner's app URI should be the first URI.
* This clarifies issue #825
@E-B-Smith
Copy link
Contributor

I updated the documentation to make sure it's clear that the app's URI scheme should be the first one listed in the Info.plist file.

Release 0.24.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants