Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate warning added in the functions using share sheet in BranchUniversalObject.h #631

Merged
merged 1 commit into from May 24, 2017
Merged

Deprecate warning added in the functions using share sheet in BranchUniversalObject.h #631

merged 1 commit into from May 24, 2017

Conversation

parthkalavadia
Copy link
Contributor

Deprecate Warning added on functions using Share Sheet in BranchUniversalObject - "Use presentActivityViewControllerFromViewController in BranchShareLink". This will give an intuition to the developer about the use of BranchShareLink.

@BranchMacMini
Copy link
Contributor

Result of Integration 1

Duration: 4 minutes and 41 seconds
Result: All 179 tests passed, but please fix 1 warning.
Test Coverage: 57%

@E-B-Smith E-B-Smith self-requested a review May 24, 2017 00:35
E-B-Smith
E-B-Smith reviewed May 24, 2017
View reviewed changes
Copy link
Contributor

@E-B-Smith E-B-Smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@E-B-Smith E-B-Smith merged commit 882bb19 into staging May 24, 2017
@E-B-Smith E-B-Smith deleted the deprecateWarningInBUO branch May 24, 2017 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@E-B-Smith E-B-Smith E-B-Smith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parthkalavadia @BranchMacMini @E-B-Smith