Add color provider to white oak leaves. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandcraf06
added a commit
that referenced
this pull request
Jan 28, 2021
…egacy leaves textures too #71
|
After these changes, the break particles for white oak leaves and hedge were too dark. So I've improved for that the texture tint is fully managed via the color provider, like vanilla leaves. Thanks for the help and the report! Will be fixed in the next update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
White oak leaves (and small hedge) do not have a color provider.
Which causes some issues with mods like falling leaves or my upcoming LambdaMap mod.
Here's the issue in action:
As there's no color provider it defaults to white.
This PR aims at adding the color provider to solve this issue, and I modified the models of white oak leaves and small hedge to not use the tint index as it would color the texture incorrectly as it's not a gray scale texture.