Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add versão na url dos endpoints #25

Merged
merged 3 commits into from Feb 18, 2020
Merged

feat: add versão na url dos endpoints #25

merged 3 commits into from Feb 18, 2020

Conversation

mukaschultze
Copy link
Member

Muda a URL do CEP de https://brasilapi.com.br/api/cep/[cep] para https://brasilapi.com.br/api/v1/cep/[cep]

Closes #12

@vercel
Copy link

vercel bot commented Feb 18, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/filipedeschamps/brasilapi/gxhrv16i6
✅ Preview: https://brasilapi-git-fork-mukaschultze-master.filipedeschamps.now.sh

Copy link
Member

@filipedeschamps filipedeschamps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SENSACIONAL @mukaschultze !! Só um detalhe importante: para termos a flexibilidade de fazer o bump de uma só rota e não de todas, é importante colocar a versão v1 dentro o do recurso principal e não fora.

Então ao invés de:

https://brasilapi.com.br/api/v1/cep/[cep]

Deveria ser:

https://brasilapi.com.br/api/cep/v1/[cep]

Assim conseguiremos criar uma v2 do cep sem precisar duplicar/forçar o release da versão v2 dos outros endpoints 👍

@mukaschultze
Copy link
Member Author

Vdd, vdd, nem me liguei nisso

@mukaschultze
Copy link
Member Author

Corrigido

@filipedeschamps
Copy link
Member

Matou a pau!!!! E cara, eu to apaixonado pelo auto-deploy do Now, olha isso que legal: https://brasilapi-gxhrv16i6.now.sh/api/cep/v1/05010000

Na lata!!! Merging e adicionando você na lista de contribuidores 👍

@filipedeschamps filipedeschamps merged commit ba65abd into BrasilAPI:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versionamento dos endpoints
2 participants