-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update cnpj doc #509
base: main
Are you sure you want to change the base?
fix: update cnpj doc #509
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@RodriAndreotti pronto pra review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notei que algumas propriedades foram removidas da documentação, estas propriedades não são mais retornadas no get da api?
PS.: Acho que apaguei um comentário seu por acidente... rs
Mals!
@RodriAndreotti deu http 500 num E2E dentro do tests/fipe-v1.test.js . Consegue dar um re-run? |
Infelizmente não consigo, tenta fazer um amend no PR, teoricamente ele vai rodar de novo. |
Aparentemente o retorno de um dos endpoints mudou, acho que vamos precisar corrigir o teste correspondente. |
@vhs94 Conseguiria ajustar esse teste para o PR passar? Acredito que podemos substituir esse Desta forma, se o retorno mudar novamente, a gente mantém o teste funcionando. |
"opcao_pelo_mei": { | ||
"type": "boolean" | ||
}, | ||
"data_opcao_pelo_mei": { | ||
"type": "string", | ||
"format": "date" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essa data pode ser null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LorhanSohaky fiquei com duvida nesse cara ai, posso colocar type date e format nullable?
"type": "date",
"format": "nullable"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vhs94 Acho que neste caso daria para usar um anyOf, semelhante ao sugerido nesta resposta aqui:
https://stackoverflow.com/a/70658334
O que acham?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | ||
"data_exclusao_do_mei": { | ||
"type": "string", | ||
"format": "date" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essa data pode ser null
Kudos, SonarCloud Quality Gate passed! |
feito man @RodriAndreotti |
update docs de acordo com o response do endpoint abaixo: