Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: testes quebrando pipeline devido a mudança no retorno da api #584

Closed

Conversation

LucasAlencarCosta
Copy link
Contributor

fix #583
Devido a mudança no retorno da api da Sefaz os testes da mesma vinham quebrando e travando as pull requests.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
brasilapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 2:51pm

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
33.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@LorhanSohaky LorhanSohaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito obrigado pela contribuição. O que acha de modificar a saída da API para que fique compatível com o que temos hoje? Pois assim a v1 continua funcionando plenamente, caso contrario a v1 teria que ser marcada como descontinuada e uma v2 seria necessária

@LucasAlencarCosta
Copy link
Contributor Author

Muito obrigado @LorhanSohaky pela avaliação da pr, abri outra com as devidas correções.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testes quebrando no ncm.
2 participants