Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Window Title #12

Merged
merged 9 commits into from
Aug 29, 2022
Merged

Change Window Title #12

merged 9 commits into from
Aug 29, 2022

Conversation

Affehund
Copy link
Contributor

This PR adds a mixin to change the Window Title
Bildschirmfoto 2022-08-29 um 11 30 24
Bildschirmfoto 2022-08-29 um 11 35 50

@congueror
Copy link
Contributor

I believe that the title should be something like "Minecraft Brass" or "Minecraft // Brass" instead. Since the main game is Minecraft, I don't think it should be abbreviated.

@Matyrobbrt Matyrobbrt added mixins enhancement New feature or request labels Aug 29, 2022
Copy link
Contributor

@Matyrobbrt Matyrobbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not precisely sure if the modded indicator should be removed, I'd advocate for keeping it.

@Affehund
Copy link
Contributor Author

Affehund commented Aug 29, 2022

I'm not precisely sure if the modded indicator should be removed, I'd advocate for keeping it.

I think it just looks much cleaner if we remove the * indicator, but we could keep it.
And I think it is clear that it is modded as it there is a different name.

…xin.java

Co-authored-by: matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
@congueror
Copy link
Contributor

I'm not precisely sure if the modded indicator should be removed, I'd advocate for keeping it.

I think it just looks much cleaner if we remove the * indicator, but we could keep it. And I think it is clear that it is modded as it there is a different name.

I agree, * is used to indicate the client is modded, so I think the whole "Minecraft Brass" does that very well

@Affehund
Copy link
Contributor Author

I'm not precisely sure if the modded indicator should be removed, I'd advocate for keeping it.

I think it just looks much cleaner if we remove the * indicator, but we could keep it. And I think it is clear that it is modded as it there is a different name.

I agree, * is used to indicate the client is modded, so I think the whole "Minecraft Brass" does that very well

Ok, then I would leave it how it is, unless someone is strictly against it.

Copy link
Contributor

@DaRealTurtyWurty DaRealTurtyWurty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the * should really be present here. Its more of a standardization than anything else, not about whether it makes sense or not. People very quickly associate * with being modded, so I don't think it makes sense to ignore that standard.

@Matyrobbrt Matyrobbrt merged commit d39a684 into BrassMC:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mixins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants