-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Window Title #12
Conversation
I believe that the title should be something like "Minecraft Brass" or "Minecraft // Brass" instead. Since the main game is Minecraft, I don't think it should be abbreviated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not precisely sure if the modded indicator should be removed, I'd advocate for keeping it.
src/mixin/java/io/github/brassmc/brassloader/mixin/MinecraftMixin.java
Outdated
Show resolved
Hide resolved
I think it just looks much cleaner if we remove the * indicator, but we could keep it. |
…xin.java Co-authored-by: matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
I agree, * is used to indicate the client is modded, so I think the whole "Minecraft Brass" does that very well |
Ok, then I would leave it how it is, unless someone is strictly against it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the *
should really be present here. Its more of a standardization than anything else, not about whether it makes sense or not. People very quickly associate *
with being modded, so I don't think it makes sense to ignore that standard.
This PR adds a mixin to change the Window Title
![Bildschirmfoto 2022-08-29 um 11 30 24](https://user-images.githubusercontent.com/42092761/187171417-106da581-da6e-4395-b8ab-4e00ab3dae67.png)
![Bildschirmfoto 2022-08-29 um 11 35 50](https://user-images.githubusercontent.com/42092761/187171664-36a0afd3-1025-4ba2-bb78-45989289bf18.png)