test: reduce noise from flaky test #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The object being tested involves spawning a process, along with a background thread, so inherently has a race condition. This has been historically semi stable but to prevent noise we have it sleep, to give the background thread some extra time. The duration is arbitrary, just didn't want to make it too long.
Testing
Ideally we would measure the failure rate over time, but this will have to be manually observed until there is a way to do that.
Time to review
30 sec