New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load-scenes: make faster and clearer #347
Comments
We can definitely add some logging to make it more clear when a pre-existing scene list is being used. This should show up when you specify debug logging, but I agree it should always be logged to make it clear from the output what is going on. Regarding performance, this is the main reason why loading statsfiles was deprecated - with the default settings and downscale factors, processing the video is usually pretty fast. However, there are certainly a lot of ways Thanks for the feedback! |
Disallow combining `load-scenes` with detectors to avoid confusion. #347
Remove `SceneLoader` and instead use the loaded scenes to bypass detection entirely. This provides a major performance boost while still supporting all required output options. Fixes #347
This is now fixed in |
Disallow combining `load-scenes` with detectors to avoid confusion. #347
Remove `SceneLoader` and instead use the loaded scenes to bypass detection entirely. This provides a major performance boost while still supporting all required output options. Fixes #347
Hi!
I've just tried out the new feature, #294
I'd like to suggest a couple of things how it could me made a bit better.
Problem/Use Case
First thing: way I see it, primary use case of "load-scenes" is to save time on detection when a single video must be processed several times. There are other use cases, of course, but for this one it doesn't do much good: detection via the list takes nearly as much time as without it.
Another thing is that currently I can't be certain if the script works with the list at all. At first I made a list without "-s" argument, then I read the document and added the argument, and didn't notice any difference.
Solutions
It would be great to make it so having the .csv allows to skip the detection process entirely (if that's even possible of course).
Also would be nice if the script informed that it currently uses the list instead of a detection from scratch.
Thank you for your amazing work!
The text was updated successfully, but these errors were encountered: