Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load-scenes: make faster and clearer #347

Closed
toomanynights opened this issue Aug 17, 2023 · 2 comments
Closed

load-scenes: make faster and clearer #347

toomanynights opened this issue Aug 17, 2023 · 2 comments
Milestone

Comments

@toomanynights
Copy link

Hi!

I've just tried out the new feature, #294
I'd like to suggest a couple of things how it could me made a bit better.

Problem/Use Case

First thing: way I see it, primary use case of "load-scenes" is to save time on detection when a single video must be processed several times. There are other use cases, of course, but for this one it doesn't do much good: detection via the list takes nearly as much time as without it.

Another thing is that currently I can't be certain if the script works with the list at all. At first I made a list without "-s" argument, then I read the document and added the argument, and didn't notice any difference.

Solutions

It would be great to make it so having the .csv allows to skip the detection process entirely (if that's even possible of course).
Also would be nice if the script informed that it currently uses the list instead of a detection from scratch.

Thank you for your amazing work!

@Breakthrough
Copy link
Owner

Breakthrough commented Aug 22, 2023

We can definitely add some logging to make it more clear when a pre-existing scene list is being used. This should show up when you specify debug logging, but I agree it should always be logged to make it clear from the output what is going on.

Regarding performance, this is the main reason why loading statsfiles was deprecated - with the default settings and downscale factors, processing the video is usually pretty fast. However, there are certainly a lot of ways load-scenes could probably be improved performance-wise, so happy to look more into that for the next release.

Thanks for the feedback!

@Breakthrough Breakthrough added this to the v0.6.3 milestone Aug 22, 2023
Breakthrough added a commit that referenced this issue Mar 6, 2024
Disallow combining `load-scenes` with detectors to avoid confusion. #347
Breakthrough added a commit that referenced this issue Mar 6, 2024
Remove `SceneLoader` and instead use the loaded scenes to bypass detection entirely.

This provides a major performance boost while still supporting all required output options.

Fixes #347
@Breakthrough
Copy link
Owner

Breakthrough commented Mar 6, 2024

This is now fixed in develop and will be included in v0.6.3. The load-scenes command now skips detection and produces output much faster.

Breakthrough added a commit that referenced this issue Apr 18, 2024
Disallow combining `load-scenes` with detectors to avoid confusion. #347
Breakthrough added a commit that referenced this issue Apr 18, 2024
Remove `SceneLoader` and instead use the loaded scenes to bypass detection entirely.

This provides a major performance boost while still supporting all required output options.

Fixes #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants