Fixed issue with extra ampersand being included right after question mark. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mark. An extra ampersand was being included after the question mark when appending query string parameters. https://www.example.com?¶meter1=value1 This caused problems with requests to controller methods on the server that included optional parameters. The request did not get routed to the correct controller method and resulted in a 404. Note that supplying values for the optional parameters was a workaround.
steveschmitt
added a commit
that referenced
this pull request
Apr 3, 2021
|
Thanks, and sorry it took so long! |
|
Your fix is included in release 2.0.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extra ampersand was being included after the question mark when appending query string parameters.
https://www.example.com?¶meter1=value1
This caused problems with requests to controller methods on the server that included optional parameters. The request did not get routed to the correct controller method and resulted in a 404.
Note that supplying values for the optional parameters was a workaround.
I extracted the logic from the two adapters that I was having problems with to a new file named adapter-core.ts (should this go elsewhere or be named differently?) and resolved the issue there. Note that there were other adapters which had the same issue. I could apply this same fix there if this looks OK.