Correctly check for PropertyChange action #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well not sure how this slipped by for so long. You fixed ONE of the TWO companion errors ... the other being a few lines above where it said As you noted, if you only make the fix you caught, stashing no longer works. But if we fix BOTH, we're in business. I fixed both error on our end (see 7815afb0d4) so I won't be able to pull. But THANK YOU for catching this and contributing! |
wardbell
added a commit
that referenced
this pull request
Nov 29, 2014
See #26 Coincidental change to saveQueuing.spec to remove last ".getProperties" call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the check for propertyChange is not working (It compares twice undefined). This PR fixes this. But as consequence stashing no longer happens for newly created ToDo entities, since for them no propertyChange event is raised.