Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fixes for working with Olingo OData v2 server #41

Closed
wants to merge 3 commits into from
Closed

Various small fixes for working with Olingo OData v2 server #41

wants to merge 3 commits into from

Conversation

dharapvj
Copy link
Contributor

When we tried to use Breeze with Olingo as backend OData provider... we faced with series of issues (some times with specific behavior of Olingo and sometimes due to issues in breeze odata adapter).

This pull request is a attempt to contribute back those changes to breeze community.

I have tried not to disturb any of the existing code. I do not know breeze enough to confidently say that all these changes will work perfect for you. Also am being java developer, I do not have running environment to see breeze development. Hence you may need to edit some of these changes before merging .. but their core value should become helpful to you and others in the community.

@dharapvj
Copy link
Contributor Author

Just an update:

I have realized that the encodeParams call which I have used in commit 460cc71 does not work and throws javascript error.

I had used $.param() for this in my code. But I was not sure if you have hard dependency on JQuery or not so at the last minute, I replaced it with your internal encodeParams method before sending this pull request.

Only way to fix this is to move encodeParams to breeze.core namespace from breeze ajax adapter. Let me know if you want me send pull request for this as well.

@dharapvj
Copy link
Contributor Author

dharapvj commented Jun 4, 2015

ping!

If this request is not acceptable.. can you give feedback so that I can update it as per your instructions and try to re-submit,,

@jtraband
Copy link
Contributor

jtraband commented Jun 4, 2015

Sorry for not responding earlier. We are working on an Olingo OData 4 adapter right now ( using https://olingo.apache.org/doc/javascript/) that involves changes to other areas in breeze and didn't want to take a commit until we release the new adapter and see what else might be broken. I'm hoping to have this out within two weeks.

In the process, I will also look at moving encodeParams into breeze.core.

@dharapvj
Copy link
Contributor Author

dharapvj commented Jun 5, 2015

Ok thanks for the update!

Best of luck with olingo client !

Your library is really awesome! Let me know if there is any need / opportunity to contribute for me..

@prilling
Copy link

This PR is kind of old. Any chance this will get merged?

steveschmitt added a commit that referenced this pull request May 24, 2016
@steveschmitt
Copy link
Member

I just committed the changes from this pull request. Underlying code changed so I had to add the fixes manually. Thanks for the contribution, and thanks for your patience.

@dharapvj
Copy link
Contributor Author

Great to see the patch getting accepted and merged!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants