Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Add outputDir argument to processTSS and determineTSR #201

Closed
rpolicastro opened this issue Jul 13, 2018 · 3 comments
Closed

Comments

@rpolicastro
Copy link
Contributor

rpolicastro commented Jul 13, 2018

Would be handy to have an explicit argument, such as outputDir, to specify where you want the text files to be written if writeTable = TRUE in either processTSS or determineTSR. It's often a little more convenient than having to change the working directory for each of the commands.

@rpolicastro rpolicastro changed the title Add outputDir argument to processTSS and determineTSR [suggestion] Add outputDir argument to processTSS and determineTSR Jul 13, 2018
@vpbrendel
Copy link
Member

I don't know why one would want to change the working directory for each of the commands - that seems to be a very non-R kind of way. All calculations should be done within R on the S4 object, with output to disk an option when needed.

@rpolicastro
Copy link
Contributor Author

rpolicastro commented Jul 13, 2018

Hi Volker,

Currently when writeTable = TRUE, the text files containing the TSSs and TSRs are written to the current working directory. What this means is if you wanted to write the TSSs or TSRs to a directory other than the current working directory, you need to change directories to the new directory before running the command in R, or move the files after creation. I was suggesting adding an explicit outputDir argument so that instead of having to change directories or move the files, you can specify where you want them to be output to in the first place.

@vpbrendel
Copy link
Member

Understood, but again I don't think any of that is necessary. More straightforward would be to move files from the working directory after R is finished, if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants