Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build script breaks when package_root does not end with slash #14

Closed
amodm opened this issue Jan 3, 2023 · 1 comment · Fixed by #13
Closed

Build script breaks when package_root does not end with slash #14

amodm opened this issue Jan 3, 2023 · 1 comment · Fixed by #13

Comments

@amodm
Copy link
Contributor

amodm commented Jan 3, 2023

Currently, string concatenation is used to determine the path to be output for cargo:rustc-link-search=native=, as seen here:

swift-rs/src-rs/build.rs

Line 80 in 1ca6430

package_root, swift_target_info.target.unversioned_triple, profile

So if the package_root argument to link_swift_package does not end with a /, the build breaks, and it's not obvious to the user why that has happened.

This needs to be changed to use std::path's join mechanism instead of a simple string concatenation.
@amodm
Copy link
Contributor Author

amodm commented Jan 3, 2023

PR #13 fixes this.

@Brendonovich Brendonovich linked a pull request Jan 3, 2023 that will close this issue
Fix build failure, and miscellaneous cleanups #13
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build failure, and miscellaneous cleanups amodm/swift-rs
1 participant
@amodm