sp_blitzcache - calculation for USERSTORE_TOKENPERM looks incorrect

[Mike-Vernon]

I think the division should be (pages_kb / 1024.0 / 1024.) >= 2. instead of (pages_kb / 128.0 / 1024.) >= 2. on this line of sp_blitzcache:

SQL-Server-First-Responder-Kit/sp_BlitzCache.sql

Line 5138 in 6a6216e

SELECT @user_perm_gb = CASE WHEN (pages_kb / 128.0 / 1024.) >= 2.

if you look at the calc for the older version of sql 11 lines down it is using 1024

Also, it is using 1024 for the same calc in sp_blitz first (

SQL-Server-First-Responder-Kit/sp_BlitzFirst.sql

Line 1814 in 4d19d1a

AND SUM(pages_kb) / 1024.0 / 1024.0 >= 1; /* At least 1GB RAM overall */';

)

[BrentOzar]

Thanks for the bug report! I'll dig into it this week.

[BrentOzar]

Thanks for catching that! I've made the change, and I'm sure it works beautifully even though I didn't test it. Merged into the dev branch, will be in the August release with credit for you in the release notes.

[Mike-Vernon]

@BrentOzar - great, thanks for taking care of it! :-)