Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to rationalize 'brentozar.com' #2803

Closed
JohnDBallentineIII opened this issue Feb 28, 2021 · 2 comments
Closed

Need to rationalize 'brentozar.com' #2803

JohnDBallentineIII opened this issue Feb 28, 2021 · 2 comments
Assignees

Comments

@JohnDBallentineIII
Copy link
Contributor

Version of the script
8.01

What is the current behavior?
Seen in the code directory -
'http://www.brentozar.com' - 36 times
'https://www.brentozar.com' - 492 times
'https://brentozar.com' - 12 times
'http://brentozar.com' - 189

If the current behavior is a bug, please provide the steps to reproduce.
Stands out when looking at a column of results - sometimes as www.brentozar,com , sometimes as just brentozar.com .

What is the expected behavior?
Should be standardized. https://www.brentozar.com seems to be the most frequently used, and what the web site goes to. Others should be changed to this standard.

Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures?
N/A

@BrentOzar
Copy link
Member

Thanks for the issue. Sure, if you want to work on this, read through the contributing guide here:

https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/blob/main/CONTRIBUTING.md

JohnDBallentineIII added a commit to JohnDBallentineIII/SQL-Server-First-Responder-Kit that referenced this issue Mar 3, 2021
Fix for issue 'Need to rationalize 'brentozar.com' BrentOzarULTD#2803'
@BrentOzar
Copy link
Member

Looks good! Thanks for the pull request. Merging into the dev branch, will be in the March release with credit to you in the release notes.

@BrentOzar BrentOzar added this to the 2021-03 Release milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants