Uninstall.sql: Drops table dbo.SqlServerVersions: Only in current database / Regardless of @printOnly / Not part of PRINT

[andreasjordan]

Version of the script
Current dev-branch at GitHub

What is the current behavior?
The table dbo.SqlServerVersions is only dropped in current database
The table dbo.SqlServerVersions is dropped regardless of @printOnly
The drop statement is not included in the PRINT output

If the current behavior is a bug, please provide the steps to reproduce.
Just have a look at the code:

SQL-Server-First-Responder-Kit/Uninstall.sql

Lines 76 to 77 in 0e76863

	IF OBJECT_ID('dbo.SqlServerVersions') IS NOT NULL
	DROP TABLE dbo.SqlServerVersions;

What is the expected behavior?
In the first case (only current database) I am not sure, because it may be risky to delete all tables dbo.SqlServerVersions in all databases.
In the second case (regardless of @printOnly) I would expect that @printOnly does not delete any objects, so does not drop the table.
In the third case (PRINT output) I would expect the DROP TABLE to be included in the PRINT. This is how I found the bug: I have missed the statement and so I had a look at the code.

If you want me to code that and open a pull request, just give me a hint.

[BrentOzar]

Sure, if that's important to you and you want to contribute the code, give 'er a shot. Thanks!

[BrentOzar]

Thanks for the pull request. Merging into the dev branch, will be in the May release with credit to you in the release notes.