Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1894 validate database parameter #1902

Conversation

ShawnCrocker
Copy link
Contributor

Fixes #1894

Changes proposed in this pull request:

  • Validate @database against backup file
  • Add other validation
  • Side effects: some reformatting so I could follow logic

How to test this code:

  • Define @database parameter different to the database backup file

Has been tested on (remove any that don't apply):

  • SQL Server 2012
  • SQL Server 2016

@BrentOzar
Copy link
Member

Ooo, man, do we really need to change the line endings? The diff looks like a hot mess, so it's tough to test.

@ShawnCrocker
Copy link
Contributor Author

It's mostly nesting of BEGIN/END blocks. I went through so i could follow the logic.

Although... my local pull had line ending changes before I re-committed.

@ShawnCrocker ShawnCrocker force-pushed the Issue_1894_Validate_database_parameter branch from 41fbd72 to 2e14a72 Compare January 9, 2019 11:02
Does this fix line endings?
@BrentOzar BrentOzar merged commit 82f26bf into BrentOzarULTD:dev Jan 10, 2019
@BrentOzar
Copy link
Member

Woohoo! Nice job, sir. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants