Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexSanity -> IndexIssues #3437

Closed
wants to merge 3 commits into from

Conversation

SeanKilleen
Copy link
Contributor

@SeanKilleen SeanKilleen commented Feb 16, 2024

Supports #3250.

Did this one as a few simple replacements:

  • IndexSanity -> IndexIssues
  • index_sanity -> index_issues
  • index_issues_id -> index_issue_id (saw Brent's preference in a past PR)

Looked it over and couldn't find any issues.

Copy link
Member

@BrentOzar BrentOzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the changes to the deprecated 2005 version? The older versions are deprecated, and we're not making changes to those. Otherwise the new version looks good. Thanks!

@BrentOzar
Copy link
Member

This one's been open for a couple of months and it's now pretty far out of sync with sp_BlitzIndex, so closing.

@BrentOzar BrentOzar closed this Apr 19, 2024
@SeanKilleen
Copy link
Contributor Author

@BrentOzar No worries, I understand. I'll pick it up again and modify just the correct files next time, should go through faster. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants