New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sp_BlitzQueryStore style, comments, and typo edits #3451
Conversation
…meters; Added comments to temp tables.
It was already the pattern in this procedure, so the examples not following it stood out.
The original sentence did not make sense.
On the topic of tidying up comments, I unfortunately have no idea what "This looks for queries in the query stores that we picked up from an internal that have multiple plans in cache" is supposed to say. It looks like it has a missing word, but I don't know what. |
I know you're not going to like hearing this, but:
I totally understand that you put a lot of work into this pull request, but... just looking at the changed code makes my eyes water, and it's not fair to ask other folks to test this kind of thing for you. |
I really do want to help you get changes made, but I just need you to abide by the readme & code contributions guide so that we can get code changes tested quickly and across the finish line. Sorry about that. |
@BrentOzar Don't worry. I've suspected for quite a while that I was trying to do too much in one PR. I've now broken this down in to new issues and submitted individual PRs for each issue that could be solved by chopping up the code that was in this PR. The diffs for the new PRs are a lot easier to digest than this massive one. Furthermore, a lot of them are just text/comment changes so there shouldn't be much testing effort needed. Sorry for the email spam that this must have caused you. |
I decided to clean up anything that bothered me in
sp_BlitzQueryStore
before beginning any serious work on it. These are largely style changes. Summary:SERVERPROPERTY
in to variables. Some of these originally wereNVARCHAR
and others wereVARCHAR
. I am not sure if there is a good reason behind this, so I have gone with my the docs.ENGINEEDITION
is an exception to this and has been stored as anINT
./*Foo*/
so I've applied that everywhere other than the multi-line block comments. Previously, it has--Foo
,-- Foo
,/*foo*/
,/* Foo */
, and@Version
parameters in the@Help
text.SELECT TOP N
toSELECT TOP (N)
for consistency with other uses ofTOP
.I expect that only point 3 has even the slightest chance of breaking anything. Those variables are mostly used for Azure checks, but I don't have an Azure box to test them on.