Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rexray install image to support driver reinstallation and version update #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kaustavb12
Copy link
Contributor

Implemented the rexray related TODO points mentioned in the stack file:

# 2. TODO: would prefer on-failure restart_policy, but need to run this in script to look
# for if plugin exists first before reinstalling

Changed restart_policy to on-failure. New script detects if plugin already installed and reinstalls if given version is different from installed version or does nothing if version matches. This behavior can be tweaked using script options.

# 3. TODO: would prefer this picks a driver version, and support driver updates

Specific driver version given for script to install. Can rerun script providing different version to update driver as required. Can also configure script options to reinstall using the 'latest' tag each time it runs.

Using rexray-plugin-installer project that I created. Below are the links:

GitHub:
https://github.com/kaustavb12/rexray-plugin-installer
Docker Hub:
https://hub.docker.com/r/kaustavb12/rexray-plugin-installer

@BretFisher
Copy link
Owner

Thanks for the tool and script @kaustavb12. I'm going to leave this PR here rather than merge for teaching reasons, rather than merging. Since this is a learning repo, I'm hesitant to add too much magic and would rather people see the "manual" way to do it, and then see this PR for an alternative approach.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants