-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup some leftovers #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gavlyukovskiy
commented
Apr 2, 2024
•
edited
edited
- Use JSONPath from the RFC 9535
- improve test coverage for prefix / negative matches
- Replace gradle.properties with conditional version Make sure shuffle always uses the same seed to select random JSONPath
- Use a fixed seed in the benchmarks for JSONPath so that we always select the same keys to become JSONPath keys, it solves a problem when benchmarks were flaky in ~360k / ~415k score
- Use RFC without dashes
Use JSONPath from the RFC 9535, improve test coverage for prefix / negative matches Replace gradle.properties with conditional version Make sure shuffle always uses the same seed to select random JSONPath Use RFC <number> without dashes
Note These results are affected by shared workloads on GitHub runners. Use the results only to detect possible regressions, but always rerun on more stable machine before making any conclusions! Benchmark results (pull-request, cb8d5a7)
Benchmark results (master, 97cae59)
|
Quality Gate failedFailed conditions |
gavlyukovskiy
commented
Apr 2, 2024
Breus
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.