Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart overlap with daylight savings and auto time adjust #19

Open
elcojacobs opened this issue Nov 4, 2013 · 2 comments
Open

Chart overlap with daylight savings and auto time adjust #19

elcojacobs opened this issue Nov 4, 2013 · 2 comments

Comments

@elcojacobs
Copy link
Member

Tim Malstrom reported this behavior on the forum:
daylight-savings-bug

Quote:
"@eLco Ah, now I know what caused it! When looking in the CSV file, I saw that this particular hour had a list of data points logged twice (after 02:59, it started all over again at 02:00). Looking back in my calendar made me realize that the raspberry Pi clock had been set back automatically due to Daylight saving time in Sweden at that exact time. Odd one!"

@m-mcgowan
Copy link
Contributor

One possible fix is to store all times internally as UTC time, and then use our own axis labeling for the time axis to convert UTC to local time (with DST changes.)

Or the server manages the conversion. To avoid ambiguity all times should be stored in UTC (e.g. as millis since the epoch.) The server can then convert these to local time for the user when the times are fetched.

@JoelSlowik
Copy link

Hi,

I read through your issue tracker specifically for this case, glad to see you already have an item for it. As another use case for you, I noticed that the data was not being stored in UTC after I updated my Pi to the proper time zone for my area. Of course since the data is stored in a flat text file we can see when the timezone changed within the graph:

fullsizerender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants