Fix issue with skip! and with cloning @config.
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `after_build` blocks are called both before a model is found and after (via `set_attributes`). This means if you fire `skip!` based on some logic that only applies after a model is found it will be called before. Calling something like `skip! unless model.persisted?` is a good example of this.
While fixing this, I also noticed that configuring an importer via the `ImporterClass.new do { ... }` syntax didn't properly clone the configuration, so things such as the configuration's `after_build_blocks` were all pointing to the same object. This fixes that by adapting some syntax from Virtus' Value Object code.
|
That's great! Thank you @pnomolos! |
pcreux
pushed a commit
that referenced
this pull request
Jan 6, 2017
The `after_build` blocks are called both before a model is found and after (via `set_attributes`). This means if you fire `skip!` based on some logic that only applies after a model is found it will be called before. Calling something like `skip! unless model.persisted?` is a good example of this. Extracted from: #52
|
Merged to master as 9aa01fa |
artur-bobrushko
pushed a commit
to artur-bobrushko/Rails-CSV-importer
that referenced
this pull request
Apr 27, 2019
The `after_build` blocks are called both before a model is found and after (via `set_attributes`). This means if you fire `skip!` based on some logic that only applies after a model is found it will be called before. Calling something like `skip! unless model.persisted?` is a good example of this. Extracted from: pcreux/csv-importer#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
after_buildblocks are called both before a model is found and after (viaset_attributes). This means if you fireskip!based on some logic that only applies after a model is found it will be called before. Calling something likeskip! unless model.persisted?is a good example of this.While fixing this, I also noticed that configuring an importer via the
ImporterClass.new do { ... }syntax didn't properly clone the configuration, so things such as the configuration'safter_build_blockswere all pointing to the same object. This fixes that by adapting some syntax from Virtus' Value Object code.