Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.3 #42

Merged
merged 22 commits into from
Apr 11, 2018
Merged

1.0.3 #42

merged 22 commits into from
Apr 11, 2018

Conversation

jbkoh
Copy link
Contributor

@jbkoh jbkoh commented Apr 11, 2018

jbkoh added 20 commits April 5, 2018 18:32
@jbkoh
remove IrreflexiveProperty
e252117
@jbkoh
remove AsymetricProperty
c93e386
@jbkoh
Merge branch 'master' into 1.0.3
2d7d043
@jbkoh
update
7ab87c3
@jbkoh
Merge branch 'master' into 1.0.3
72fa6ad
@jbkoh
add definitions to Point's top classes
03f6d23
@jbkoh
change Meter to a subclass of Equipment. More updates needed as in #33
7c8514c
@jbkoh
clarify TagSets related to occupancy. #33
9d7ae42
@jbkoh
add a print to the test file
2f6da7a
@jbkoh
merge origin
db306c2
@jbkoh
make Resource a top class instead of a subclass of Point. #23
4ee3e70
@jbkoh
add build script
2efe2cf
@jbkoh
integration -> integral. #14
ee04f59
@jbkoh
fix bugs related to CO2 Sensors. #27
5788528
@jbkoh
clarify the meaning of CO2 Level Sensor, add Reheat Coil and Fire
5fb21ac 
Alarm, and structure Pump Alarms.
@jbkoh
add license and make base url configurable
ec40099
@jbkoh
more strict way of adding MeasurementProperties. Resolving #40
692fa2f
@jbkoh
change Meter as Equipment and many meter TagSets to sensor TagSets. R…
6d3f5b5 
…elated to #34
@jbkoh
add definitions to equipments
869f67a
@jbkoh
version update to 1.0.3
eff2ad5
@jbkoh jbkoh mentioned this pull request Apr 11, 2018
Closed
@jbkoh
Copy link
Contributor Author

jbkoh commented Apr 11, 2018 •
edited
Loading

hold it to accept the PR for a few minutes.
Good to go.

@gtfierro
Copy link
Member

Can I review this tomorrow before we merge it in?

@jbkoh
Copy link
Contributor Author

jbkoh commented Apr 11, 2018

Sure.

@gtfierro
Copy link
Member

LGTM

@jbkoh
Copy link
Contributor Author

jbkoh commented Apr 11, 2018

@gtfierro so, are you running it?

@gtfierro
Copy link
Member

The PR looks good to me

@jbkoh
Copy link
Contributor Author

jbkoh commented Apr 11, 2018

Okay, thanks for reviewing this together. I merge it now.

@jbkoh jbkoh merged commit b84ad6a into BrickSchema:master Apr 11, 2018
This was referenced Apr 11, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@GeorgFerdinandSchneider GeorgFerdinandSchneider mentioned this pull request Mar 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbkoh @gtfierro