Update typescript signature for stringify method #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The workaround for anyone experiencing this issue is to cast the import stringify from `safe-stable-stringify`
let serialized = (stringify as any)(obj, replacer, space) |
BridgeAR
reviewed
Aug 31, 2018
| @@ -1,3 +1,3 @@ | |||
| declare function stringify(data: any): string; | |||
| declare function stringify(value: any, replacer?: (key: string, value: any) => any, space?: string | number): string; | |||
There was a problem hiding this comment.
The replacer could also be an array of strings or numbers.
|
@c4ndybar thanks a lot for your contribution! This is definitely already an improvement as I forgot about that. Would you be so kind and also add the array replacer? |
BridgeAR
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature for
stringifyonly had the first parameter. Thereplacerandspaceparameters were not included. This PR updates the signature to match the sig ofJSON.stringify.