Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid can't build #62

Closed
licaon-kter opened this issue Feb 20, 2023 · 18 comments
Closed

F-Droid can't build #62

licaon-kter opened this issue Feb 20, 2023 · 18 comments
Assignees
Labels
critical enhancement New feature or request

Comments

@licaon-kter
Copy link

licaon-kter commented Feb 20, 2023

I guess Flutter needs to be bumped to 3.7.3 or so...

While polishing the recipe for that, we now scan the flutter cache too so...

2023-02-20 13:05:26,624 INFO: Removing Java JAR file at .pub-cache/hosted/pub.dev/signalr_flutter-0.2.0/android/libraries/signalr-client-sdk.jar
2023-02-20 13:05:26,625 INFO: Removing Java JAR file at .pub-cache/hosted/pub.dev/signalr_flutter-0.2.0/android/libraries/signalr-client-sdk-android.jar

Hmm... 214e0c7

But... they have some .jars there? https://github.com/AS-Devs/signalr_flutter/tree/master/android/libraries

Where's the source? Are they even free or open-source?

Are you gonna host a server on Azure for that?

Why not UnifiedPush instead? https://f-droid.org/en/2022/12/18/unifiedpush.html & https://gultsch.social/@daniel/109630522775489629

/PS: any chance you could set Flutter as a submodule in your repo? It will erase the need to come and open MRs in F-Droid to fix it as you control the version directly

ref: https://git-scm.com/book/en/v2/Git-Tools-Submodules

ref: https://gitlab.com/fdroid/fdroiddata/-/blob/master/templates/build-flutter.yml

/LE: disabled all the affected versions: https://gitlab.com/fdroid/fdroiddata/-/commit/d4cce58fae646db14402ee7eaf5bec0b2e5eace1

@licaon-kter licaon-kter added the enhancement New feature or request label Feb 20, 2023
BrightDV added a commit that referenced this issue Feb 20, 2023
@BrightDV
Copy link
Owner

I updated my version of Flutter & removed the package in order to do a release soon so it should fix the build.
The SignalR package was used to communicate with Formula 1's servers during a session, as they use this technology on their website & mobile app. I will open an issue to know the source of the jar.
For example, the FastF1 Python package uses a SignalR client to retrieve data during a session.

I will look to add Flutter as a submodule, thanks for the helpful resources.

@BrightDV
Copy link
Owner

The submodule should be added by 9724db4. Is there any other configuration needed?

@licaon-kter
Copy link
Author

@licaon-kter
Copy link
Author

licaon-kter commented Feb 21, 2023

I see no .flutter folder. Did you forget to add it to https://github.com/BrightDV/BoxBox/blob/main/.gitignore ?

@BrightDV
Copy link
Owner

I see no .flutter folder. Did you forget to add it to main/.gitignore ?

I messed up a bit with the submodule, but I reinstalled it, and now you can see the folder (c850272).

@BrightDV
Copy link
Owner

Yes, recipe needs to be adapted.

Eg. gitlab.com/fdroid/fdroiddata/-/blob/master/templates/build-flutter.yml#L23

In order to edit it, should I change the latest build data? https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/org.brightdv.boxbox.yml#L123

@licaon-kter
Copy link
Author

I'm testing locally, brb

@licaon-kter
Copy link
Author

...
+ .flutter/bin/flutter pub get
Downloading Material fonts...                                      937ms
Downloading Gradle Wrapper...                                       43ms
Downloading package sky_engine...                                  427ms
Downloading flutter_patched_sdk tools...                         1,508ms
Downloading flutter_patched_sdk_product tools...                 1,494ms
Downloading linux-x64 tools...                                     10.7s
Downloading linux-x64/font-subset tools...                         780ms
"es": 1 untranslated message(s).
"hi": 1 untranslated message(s).
"nb": 3 untranslated message(s).
"pa": 1 untranslated message(s).
"pt": 1 untranslated message(s).
"tr": 1 untranslated message(s).
To see a detailed report, use the untranslated-messages-file 
option in the l10n.yaml file:
untranslated-messages-file: desiredFileName.txt
<other option>: <other selection> 


This will generate a JSON format file containing all messages that 
need to be translated.
Resolving dependencies...
Because boxbox depends on flutter_localizations from sdk which depends on intl 0.18.0, intl 0.18.0 is required.
So, because boxbox depends on intl ^0.17.0, version solving failed.

next?

@BrightDV
Copy link
Owner

There are a lot of conflicts, I will add some packages in the repo directly.

BrightDV added a commit that referenced this issue Feb 21, 2023
BrightDV added a commit that referenced this issue Feb 21, 2023
@BrightDV
Copy link
Owner

You should be able to build the app now

@licaon-kter
Copy link
Author

Builds and runs fine, will you tag a new release?

@bagajohny
Copy link

Is there any issue with F-droid? I am unable to install v0.50 from github because I already have fdroid version installed. And the latest version is not showing on fdroid.

@licaon-kter
Copy link
Author

@bagajohny latest was not built and several past versions were disabled since they contained non-free codee

Future 0.5.1 will fix it...

@BrightDV
Copy link
Owner

Sorry, I was unable to release a version sooner...
I will follow the build to see if every goes fine, thanks for the help.

@licaon-kter
Copy link
Author

Done manually: https://gitlab.com/fdroid/fdroiddata/-/commit/bb18a1e5906c08730a56c6adaafc53486b9f2a1b

@licaon-kter
Copy link
Author

licaon-kter commented May 29, 2023

@BrightDV
Copy link
Owner

BrightDV commented May 29, 2023

Whoops, little mistake.
This should be fixed now, a newer version of the syncfusion_flutter_pdfviewer was causing the crash.
I will try to run the same workflow as F-Droid before releasing a new version to prevent these issues.
Anyway, sorry for the problems ;)

The new release is published now!

@licaon-kter
Copy link
Author

Thanks https://gitlab.com/fdroid/fdroiddata/-/commit/18e57452a8a43a5d7b2d93b0641610631e9cc856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants