Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move contestId out from under Candidate in RawContestConfig #478

Closed
HEdingfield opened this issue Jul 25, 2020 · 0 comments
Closed

Move contestId out from under Candidate in RawContestConfig #478

HEdingfield opened this issue Jul 25, 2020 · 0 comments

Comments

@HEdingfield
Copy link
Contributor

This is confusing for two reasons:

  1. The actual contestId that's provided by the user exists under the CvrSource class already.
  2. It breaks the model of having the RawContestConfig file be a 1:1 mapping of what the .json config files look like.

This appears to only be used for Dominion tabulation, so it should probably be refactored to DominionCvrReader or maybe ContestConfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants