-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVRs with rankings > configured Maximum Number of Candidates That Can Be Ranked should throw a halting exception #808
Comments
This doesn't work naturally for ES&S files, which look like: In these files, there are columns after the max ranking. "Max ranking" essentially means that "first vote column" + "max ranking" = "last vote column". Options:
I have opted for (3), which has the downside of being excluded from this check entirely. Would appreciate thoughts on that decision. |
Is it possible for option 2 to do something like
|
Yep! It'll be somewhat brittle though: if we just check the first row, what if that voter undervoted? Or, what if that column is something like "overvote text" or something else "valid" that gets tripped up by this? I think another option is:
This is a little less brittle, but still has failure cases (e.g. wouldn't support |
Can we piggyback off of the current validation logic in I can also try to confirm the format of the column headers with ES&S. If we can be confident in those that would be even easier. |
I'm pretty sure |
CVR: CSV CVRs - more ranks than configured.csv
Config: undefined_more-rankings-than-configured.json
The CVR above has 4 rankings, but is configured for a maximum of 3.
In the Winning Rules tab there is a setting for
Maximum Number of Candidates That Can Be Ranked
. If any CVR has a ranking that exceeds this limit it should fail validation as a halting exception.This ticket is following up with the conversation here in #786.
The text was updated successfully, but these errors were encountered: