remove TODOs from code #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HEdingfield
approved these changes
Jun 23, 2019
| @@ -917,7 +915,6 @@ private void recordSelectionForCastVoteRecord( | |||
| continue; | |||
| } | |||
|
|
|||
| // TODO: it's weird to have this check here | |||
There was a problem hiding this comment.
It seems like the rest of the stuff below here may have been part of the TODO? Does it make sense on its own?
// handle testing in unit tests, remove this assert, and add break statement
// at end of this for loop
There was a problem hiding this comment.
Oops. I just went ahead and did what @moldover suggested, except for adding a unit test. I'll create a new issue for that part.
tarheel
added a commit
that referenced
this pull request
Jun 23, 2019
tarheel
added a commit
that referenced
this pull request
Jun 24, 2019
fix silly (but innocuous) mistake in #306
|
We've also got FIXMEs in there that we should probably remove too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each one, I either a) verified that it was no longer relevant, b) verified that an issue already existed (see #132), or c) created a new issue (see #304 and #305).