Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #567 multiple return statements #600

Merged
merged 2 commits into from Jun 7, 2022
Merged

fix for #567 multiple return statements #600

merged 2 commits into from Jun 7, 2022

Conversation

moldover
Copy link
Contributor

@moldover moldover commented Jun 6, 2022

Fix for #567 multiple return statements.

tarheel
tarheel approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@tarheel tarheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did you confirm that these are the only offending methods via a manual audit, or did you use an automated check?

src/main/java/network/brightspots/rcv/Tabulator.java Show resolved Hide resolved
@moldover
Copy link
Contributor Author

moldover commented Jun 6, 2022

Thanks! Did you confirm that these are the only offending methods via a manual audit, or did you use an automated check?

Manual audit. It's not bad.

@moldover moldover merged commit 70c93d7 into develop Jun 7, 2022
@moldover moldover deleted the multiple_returns_567 branch June 7, 2022 00:35
@moldover moldover mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarheel tarheel tarheel approved these changes

@HEdingfield HEdingfield HEdingfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moldover @tarheel @HEdingfield