Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License updates #604

Merged
merged 7 commits into from Jul 21, 2022
Merged

License updates #604

merged 7 commits into from Jul 21, 2022

Conversation

moldover
Copy link
Contributor

@moldover moldover commented Jul 11, 2022

@rrojas350
Copy link

The contributor's guide and licensing statement look good to me.

My only question, and maybe Chris can answer it, is that I noticed line 3 of .idea/copyright/BrightSpotsCopyrightProfile.xml mentions the GNU Affero General Public License. Should it include MPL 2.0 or be replaced, since MPL is going to be the default licensing for vendors?

@moldover
Copy link
Contributor Author

@rrojas350 see my question here: #551 ... the copyright notice needs to be entirely replaced on every source file (and the template)

@moldover moldover merged commit 88afa60 into develop Jul 21, 2022
@moldover moldover deleted the license_updates_551 branch July 21, 2022 19:24
@moldover
Copy link
Contributor Author

@artoonie I realized there is something we should consider - I updated the license file in the test_data repo, that might conflict with how you are using rcvis. are you ok with updating the rcvis license if needed? check out more background in issue #551

@artoonie
Copy link
Collaborator

Thanks for the heads up!

RCVis doesn't use any of the test_data, actually - that was for a separate project. Some files in RCVis may have been generated by the tabulator, but not as part of test_data.

@moldover
Copy link
Contributor Author

Ok cool, in that case we can leave test_data with the new license and we're gg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants